Development#202
Merged
Merged
Conversation
Deleted an Exit statement following a throw in the PowerShell Core check, as it was unreachable code.
Renamed Visual C++ Redistributable for Visual Studio 2022 entries to Microsoft Visual C++ v14 Redistributable for x64, x86, and Arm64. Updated their download URIs to use the aka.ms/vc14 links.
Introduces a step to pull the latest changes from the development branch in the update-manifest GitHub Actions workflow, ensuring the workflow operates on the most recent code.
Replaces all Write-Host statements with Write-Information for improved logging practices and better output control. Also sets error, information, and progress preferences at script start for consistent behavior.
Updated all GitHub Actions workflow steps to use 'pwsh' instead of 'powershell' for improved compatibility and consistency with PowerShell Core. This affects update-manifest.yml, update-module.yml, and validate-module.yml.
Bumped the version and product codes for Microsoft Visual C++ v14 Redistributable (x64 and x86) to 14.50.35719.0 in VisualCRedistributables.json to reflect the latest release.
Standardizes the release identifier for Visual C++ Redistributable 2022 to '14' in all scripts, tests, and manifest files. This improves consistency and aligns with the versioning used in the manifest JSON and related automation.
Changed the expected output in the Get-VcList test to match the new naming convention for Visual C++ v14 Redistributable, supporting Arm64, x64, and x86 architectures.
Fix Regex
The GitHub Actions workflow now triggers on changes in the tests directory. The Get-VcList test assertion is relaxed to use -BeLike instead of -BeLikeExactly for better flexibility.
Changed the shell from 'pwsh' to 'powershell' in the validate-module workflow to ensure compatibility with the environment.
Enhanced the 'Release' property extraction to handle cases where the display name matches 'v<digits>' in addition to the previous year-based pattern. This improves detection of release versions from software display names.
Replaces the vcredist.png image with a new version and adds a new Microsoft-VisualStudio2026.png icon to the img directory.
Test Results 1 files 106 suites 3m 8s ⏱️ For more details on these failures, see this check. Results for commit b8e1667. ♻️ This comment has been updated with latest results. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
The Codecov upload step in the GitHub Actions workflow and the test context for importing VcRedists into a target tenant have been commented out. This may be to temporarily disable coverage reporting and tenant import tests, possibly due to issues with authentication or external dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2022release property to14to reflect latest versionGet-InstalledVcRedistreturns the correct architecture on ARM64 ARM64 Redistributables are listed with x86 Architecture #191